docs(radio-button): add a bit of padding to radio button example #7433
Conversation
googlebot
added
the
cla: yes
| @@ -1 +1,4 @@ | |||
| /** No CSS for this example */ | |||
| .mat-radio-button:not(:last-child) { | |||
There was a problem hiding this comment.
This could be a little more robust as:
.mat-radio-button + .mat-radio-button {
margin-left: 16px;
}Also the comment isn't really necessary.
There was a problem hiding this comment.
@crisbeto I think the way I did it allows for more flexibility. If someone has an element other than a .mat-radio-button as a sibling, then I think yours breaks down; whereas with my way, you could have a radio button, some other element, and then another radio button and mine would still put a bit of space.
That being said, I think your way might be faster. What do you think about doing .mat-radio-button ~ .mat-radio-button? Using this should allow us to select all the radio button siblings, no matter if they are immediately adjacent or not and would still be a little faster than :not().
There was a problem hiding this comment.
That works as well. My only issue with the first approach was it could've broken if we shuffled the DOM around.
kara
added
pr: needs review
and removed
action: merge
crisbeto
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
A spoonful of padding helps the
radio-buttonsgo down! ☂️Before:
After:
